Repository navigation
fix(wizard-ask): let one call carry a whole connector form - #1319
Merged
Merged
Conversation
The per-call question limit was eight, below the widest data-warehouse connector's advertised field set. The databases this step is mostly offered for sat at or over it, so the agent could not collect one in the single call the guidance asks for, and handed the user a browser link instead. Both harness facades now read one shared ASK_MAX_QUESTIONS_PER_CALL, and the tool description and the batching nudge quote it, so the limit and what the agent is told about it cannot drift. The description also says what to do with a subject wider than one call: split it over consecutive calls reusing the same `subject`, which the batching guard already allows, rather than abandoning it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 4c9a85df-9b83-4a2f-9a8e-6a127402705f
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
gewenyu99
approved these changes
Sep 23, 2026
gewenyu99
added a commit
that referenced
this pull request
Sep 23, 2026
Brings in main (#1319). No conflicts. Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
gewenyu99
added a commit
that referenced
this pull request
Sep 24, 2026
Carries main's #1319 and #1235 through the callable host: - runProgram loads wizard flags before it resolves the run, so the integration prompt reads the AI Observability and Logs kill switch. artifacts.reportFile is now set just before the agent starts, so a pre-run failure leaves it absent. - One excludedIntegrationTaskTypes feeds both program registries. - The legacy adapter records task outcomes for the e2e harness, and TASK_OUTCOMES_KEY lives in runner/shared/types to stay out of the startup closure. Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The seeded data-warehouse step collects a source's connection details through
wizard_ask, and both harness facades capped one call at eight questions. Thatis below what the connectors advertise: the widest source forms carry nine
fields, and several of the databases this step is most often offered for sit at
exactly eight, leaving no room for a confirmation or a corrected retry. A form
with an SSH tunnel expands further still, because the tunnel field is a
composite.
The guidance around the tool reads as "one subject, one call", and nothing told
the agent that a subject too wide for one call may simply be split. So a source
the wizard could have connected in the terminal was instead reported as
uncollectable and handed back as a link for the user to follow themselves — the
exact hand-off the in-CLI setup exists to avoid.
Changes
ASK_MAX_QUESTIONS_PER_CALL, sized to carry the widest connectorform with a little headroom, replaces the literal
8in the MCP facade's zodschema and the pi facade's typebox mirror. The orchestrator runs on pi, so
keeping the two level matters.
hard-coding a number, so the limit and what the agent is told about it cannot
drift apart.
collect it over consecutive calls reusing the same
subject— which theper-subject batching guard already permits — and never treat the width as a
reason to fall back to a link.
No change to the per-run call cap, the adjacency threshold, the refund
behaviour, or any analytics property.
Test plan
pnpm typecheck,npx vitest run(3209 tests, 184 files, all passing), andpnpm lint(0 errors) on the full tree.description quotes it and carries the split-don't-abandon instruction; the
nudge quotes it; and the pi schema — the one actually in effect for the
orchestrator — caps at the shared constant rather than a harness-local number.
Created with PostHog Desktop
🤖 Generated with Claude Code